[vlc-devel] [PATCH 01/17] dash: added segmentlist

[Christopher Müller]

> -----Ursprüngliche Nachricht-----
> Von: Hugo Beauzée-Luyssen [mailto:beauze.h at gmail.com]
> Gesendet: Montag, 30. Jänner 2012 17:08
> An: Mailing list for VLC media player developers
> Cc: Christopher Mueller
> Betreff: Re: [vlc-devel] [PATCH 01/17] dash: added segmentlist
> 
> On Mon, Jan 30, 2012 at 2:48 PM,  <Christopher at mailsrv.uni-klu.ac.at>
> wrote:
> > From: Christopher Mueller <christopher.mueller at itec.aau.at>
> >
> > ---
> >  modules/stream_filter/dash/mpd/SegmentList.cpp |   35
> +++++++++++++++++++
> >  modules/stream_filter/dash/mpd/SegmentList.h   |   43
> ++++++++++++++++++++++++
> >  2 files changed, 78 insertions(+), 0 deletions(-)
> >  create mode 100644 modules/stream_filter/dash/mpd/SegmentList.cpp
> >  create mode 100644 modules/stream_filter/dash/mpd/SegmentList.h
> >
> > diff --git a/modules/stream_filter/dash/mpd/SegmentList.cpp
> b/modules/stream_filter/dash/mpd/SegmentList.cpp
> > new file mode 100644
> > index 0000000..653d641
> > --- /dev/null
> > +++ b/modules/stream_filter/dash/mpd/SegmentList.cpp
> > @@ -0,0 +1,35 @@
> > +/*
> > + * SegmentList.cpp
> > +
> ***********************************************************************
> ******
> > + * Copyright (C) 2010 - 2012 Klagenfurt University
> > + *
> > + * Created on: Jan 27, 2012
> > + * Authors: Christopher Mueller <christopher.mueller at itec.uni-
> klu.ac.at>
> > + *          Christian Timmerer  <christian.timmerer at itec.uni-
> klu.ac.at>
> > + *
> > + * This program is free software; you can redistribute it and/or
> modify
> > + * it under the terms of the GNU Lesser General Public License as
> published
> > + * by the Free Software Foundation; either version 2.1 of the
> License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA
> 02110-1301, USA.
> > +
> ***********************************************************************
> ******/
> > +
> > +#include "SegmentList.h"
> > +
> > +using namespace dash::mpd;
> > +
> > +SegmentList::SegmentList    ()
> > +{
> > +
> > +}
> > +SegmentList::~SegmentList   ()
> > +{
> > +}
> > diff --git a/modules/stream_filter/dash/mpd/SegmentList.h
> b/modules/stream_filter/dash/mpd/SegmentList.h
> > new file mode 100644
> > index 0000000..6fe9f02
> > --- /dev/null
> > +++ b/modules/stream_filter/dash/mpd/SegmentList.h
> > @@ -0,0 +1,43 @@
> > +/*
> > + * SegmentList.h
> > +
> ***********************************************************************
> ******
> > + * Copyright (C) 2010 - 2012 Klagenfurt University
> > + *
> > + * Created on: Jan 27, 2012
> > + * Authors: Christopher Mueller <christopher.mueller at itec.uni-
> klu.ac.at>
> > + *          Christian Timmerer  <christian.timmerer at itec.uni-
> klu.ac.at>
> > + *
> > + * This program is free software; you can redistribute it and/or
> modify
> > + * it under the terms of the GNU Lesser General Public License as
> published
> > + * by the Free Software Foundation; either version 2.1 of the
> License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA
> 02110-1301, USA.
> > +
> ***********************************************************************
> ******/
> > +
> > +#ifndef SEGMENTLIST_H_
> > +#define SEGMENTLIST_H_
> > +
> > +#include "mpd/SegmentInfo.h"
> > +
> > +namespace dash
> > +{
> > +    namespace mpd
> > +    {
> > +        class SegmentList : public SegmentInfo
> > +        {
> > +            public:
> > +                SegmentList             ();
> > +                virtual ~SegmentList    ();
> > +        };
> > +    }
> > +}
> > +
> > +#endif /* SEGMENTLIST_H_ */
> > --
> > 1.7.0.4
> >
> 
> I guess you have something in mind, but I can't find the use for an
> empty class?
> 

Actually I have just implemented what is needed to parse the reduced isoffmain profile form the dataset but SegmentList has more attributes in the standard, which we will need in the future for other profiles or the full isoffmain. Of course we could currently also use the SegmentInfo but this would not be so clean due to the fact that there is no segmentinfo in this profile.

BR
Chris