[vlc-devel] [PATCH 05/17] dash: chunk added optionalurl setter

[Hugo Beauzée-Luyssen]

2012/1/30 Christopher Müller <christopher.mueller at itec.uni-klu.ac.at>:
>> -----Ursprüngliche Nachricht-----
>> Von: vlc-devel-bounces at videolan.org [mailto:vlc-devel-
>> bounces at videolan.org] Im Auftrag von Hugo Beauzée-Luyssen
>> Gesendet: Montag, 30. Jänner 2012 17:17
>> An: Mailing list for VLC media player developers
>> Betreff: Re: [vlc-devel] [PATCH 05/17] dash: chunk added optionalurl
>> setter
>>
>> On Mon, Jan 30, 2012 at 2:48 PM,  <Christopher at mailsrv.uni-klu.ac.at>
>> wrote:
>> > From: Christopher Mueller <christopher.mueller at itec.aau.at>
>> >
>> > ---
>> >  modules/stream_filter/dash/http/Chunk.cpp |   17 ++++++++++-------
>> >  modules/stream_filter/dash/http/Chunk.h   |    1 +
>> >  2 files changed, 11 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/modules/stream_filter/dash/http/Chunk.cpp
>> > b/modules/stream_filter/dash/http/Chunk.cpp
>> > index 56d02d4..ac63737 100644
>> > --- a/modules/stream_filter/dash/http/Chunk.cpp
>> > +++ b/modules/stream_filter/dash/http/Chunk.cpp
>> > @@ -34,28 +34,31 @@ Chunk::Chunk() : startByte( 0 ),
>> >  {
>> >  }
>>
>> This is the current code, but endByte misses a default value. However
>> it doesn't seem to be used for now.
>
> I have implemented it in [PATCH 2/3] dash added byte range requests
>
>>
>> >
>> > -int         Chunk::getEndByte   () const
>> > +int                 Chunk::getEndByte       () const
>> >  {
>> >     return endByte;
>> >  }
>> > -int         Chunk::getStartByte () const
>> > +int                 Chunk::getStartByte     () const
>> >  {
>> >     return startByte;
>> >  }
>> > -
>> > -const std::string& Chunk::getUrl       () const
>> > +const std::string&  Chunk::getUrl           () const
>> >  {
>> >     return url;
>> >  }
>> > -void        Chunk::setEndByte   (int endByte)
>> > +void                Chunk::setEndByte       (int endByte)
>> >  {
>> >     this->endByte = endByte;
>> >  }
>> > -void        Chunk::setStartByte (int startByte)
>> > +void                Chunk::setStartByte     (int startByte)
>> >  {
>> >     this->startByte = startByte;
>> >  }
>> > -void        Chunk::setUrl       ( const std::string& url )
>> > +void                Chunk::setUrl           (const std::string& url
>> )
>> >  {
>> >     this->url = url;
>> >  }
>> > +void                Chunk::addOptionalUrl   (const std::string& url)
>> > +{
>> > +    this->optionalUrls.push_back(url);
>> > +}
>> > diff --git a/modules/stream_filter/dash/http/Chunk.h
>> > b/modules/stream_filter/dash/http/Chunk.h
>> > index 0409fd5..1ec46f7 100644
>> > --- a/modules/stream_filter/dash/http/Chunk.h
>> > +++ b/modules/stream_filter/dash/http/Chunk.h
>> > @@ -43,6 +43,7 @@ namespace dash
>> >                 void                setEndByte      (int endByte);
>> >                 void                setStartByte    (int startByte);
>> >                 void                setUrl          (const
>> > std::string& url);
>> > +                void                addOptionalUrl  (const
>> > + std::string& url);
>> >
>> >             private:
>> >                 std::string                 url;
>> > --
>> > 1.7.0.4

Oops my bad I forgot to check those patches

-- 
Hugo Beauzée-Luyssen