[vlc-devel] [PATCH 1/3] macosx: reenable audio items on osd

David Fuhrmann david.fuhrmann at googlemail.com
Mon Jan 30 19:50:20 CET 2012

Am 30.01.2012 um 18:53 schrieb Rémi Denis-Courmont:

> Le samedi 21 janvier 2012 09:16:45 David Fuhrmann, vous avez écrit :
>> I can look if the changes can be put elsewhere to really handle only the
>> hot keys. Or do you have a better idea?
> Key actions are an interface ONLY between the key map and the actual actions. 
> It is not meant to be called from anything other than the key map.

I don't fully understand what you mean with "key map".

> There are shortcomings in hotkey processing that would require it to be 
> removed anyway.

When do you intend to remove that code?
Currently, I don't see any good alternative for the key actions (or do I miss something)?
My main goal is to bring back the concerning functionality for VLC 2. I assume that such a big change in core you are referring to will not be back ported, so it seems to me not so problematic to use the key actions in vlc 2.

> If you abuse key actions somewhere, that will break. Don't run 
> to me for sympathy when that happens (in other words, I won't fix it).

I have no problem that the problematic calls will be removed when this breaks. Until then, perhaps they will be an alternative which is better to use. But for now, such an alternative does not seem to exist, when I understand the situation correctly.

Best regards,

More information about the vlc-devel mailing list