[vlc-devel] [PATCH 1/3] macosx: reenable audio items on osd

David Fuhrmann david.fuhrmann at googlemail.com
Mon Jan 30 20:39:31 CET 2012


Am 30.01.2012 um 20:07 schrieb Jean-Baptiste Kempf:

> On Mon, Jan 30, 2012 at 06:42:32PM +0100, David Fuhrmann wrote :
>> I want to send a friendly ping for that issue, and I would be glad to read your opinions.
>> 
>> I don't think that its a good idea to duplicate the code already implemented in hotkeys.c and enforce this osd stuff for everyone who uses the aout_volume* functions.
> 
> So far, reverting the changes back from aout is not ok.
> 
>>> I can look if the changes can be put elsewhere [in gui code] to really handle only the hot keys.
>> 
>> Jean-Baptiste, would this be acceptable for you?
> 
> Depends if it is correctly done. So far, the patches are not OK.

Yes, I know that I sent no newer patches by now.
My intention was to ask if this could possibly ok for you, before I implement something.
(See your first mail in this thread.)

Best regards,
David


More information about the vlc-devel mailing list