[vlc-devel] Adding Cook support in mkv - needs review

[Jean-Baptiste Kempf]

On Wed, Jul 04, 2012 at 12:27:27AM +0200, Denis Charmet wrote :
> +#include <arpa/inet.h>
>  #include "matroska_segment.hpp"
> -
>  #include "chapters.hpp"
> -
>  #include "demux.hpp"
> -

Sure?

> +                    p_tk->p_subpackets = (block_t**) calloc( p_tk->i_subpackets, sizeof(block_t*));
No check for NULL?

> +        if( tk->fmt.i_cat == VIDEO_ES || tk->fmt.i_cat == AUDIO_ES )
>          tk->i_last_dts = p_block->i_dts;
Needs alignment?

> -        /* The blocks are in coding order so we can safely consider that only references are in chronological order */
> -        if( p_sys->i_pts > p_sys->i_pcr + 300000 )
> +        mtime_t i_pcr = VLC_TS_INVALID;
> +        for( size_t i = 0; i < p_segment->tracks.size(); i++)
> +            if( p_segment->tracks[i]->i_last_dts > VLC_TS_INVALID &&
> +                ( p_segment->tracks[i]->i_last_dts < i_pcr || i_pcr == VLC_TS_INVALID ))
> +                i_pcr = p_segment->tracks[i]->i_last_dts;

Hmm, Laurent?

> +    /* real audio */
> +    uint32_t i_sub_packet_h;
> +    uint32_t i_frame_size;
> +    uint32_t i_subpacket_size;
> +    block_t  **p_subpackets;
> +    size_t   i_subpackets;
> +    size_t   i_subpacket;

Why not a sub-struct?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device