[vlc-devel] [PATCH] audioscrobbler: prevent an endless loop inside the main loop
freebsd-listen at fabiankeil.de
Thu Jul 5 16:52:39 CEST 2012
Fabian Keil <freebsd-listen at fabiankeil.de> wrote:
> Rémi Denis-Courmont <remi at remlab.net> wrote:
> > On Wed, 20 Jun 2012 13:28:45 +0200, Fabian Keil
> > <freebsd-listen at fabiankeil.de> wrote:
> > > The attached patch fixes a compiler warning and might fix the
> > > issue reported in: https://trac.videolan.org/vlc/ticket/6286.
> > >
> > > I don't have an account an thus couldn't test it, though.
> > Might as well use INT64_MIN as initializer. That would be simpler.
> Thanks for the feedback.
> Grepping around in vlc, I couldn't find a single instance where
> INT64_MIN is used to initialize an mtime_t. The commonly used
> integers seem to be 0 and -1, and now that I know that mtime_t is
> signed, I prefer -1 as well.
> I also realized that the second chunk of my patch shouldn't be
> necessary. Attached is an updated version that only contains
> the first chunk and initializes with -1 instead of 0.
> Does this address your concern about simplicity, or do
> you still prefer INT64_MIN?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 196 bytes
Desc: not available
More information about the vlc-devel