[vlc-devel] Patch for iOS Build
    Felix Paul Kühne 
    fkuehne.videolan at gmail.com
       
    Thu Jul 12 00:42:06 CEST 2012
    
    
  
Hi Jörg,
On 11.07.2012, at 22:48, Jörg Bleyel wrote:
> .. Please Check if the syntax is correct…
Please split the patch, since it affects 2 files which aren't related at all. Additionally, 2 different actions are performed there. Additionally, please provide meaningful documentation about your changes in the respective patches. Regarding the configure.ac patch, you're introducing tabs, which is considered as evil in VLC land except for Makefiles.
Cheers,
Felix
    
    
More information about the vlc-devel
mailing list