[vlc-devel] [vlc-commits] Qt: PLModel: fix string conversion for winxx

[Rémi Denis-Courmont]

Le jeudi 19 juillet 2012 15:41:08 Francois Cartegnie, vous avez écrit :
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Thu Jul 19
> 14:40:32 2012 +0200| [0555a4ce8659d4b20bf5b19aa1168b3cdab41fe4] |
> committer: Francois Cartegnie
> 
> Qt: PLModel: fix string conversion for winxx
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0555a4ce8659d4b20b
> > f5b19aa1168b3cdab41fe4
> 
> ---
> 
>  modules/gui/qt4/components/playlist/standardpanel.cpp |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/gui/qt4/components/playlist/standardpanel.cpp
> b/modules/gui/qt4/components/playlist/standardpanel.cpp index
> a9b8f0d..ec98b45 100644
> --- a/modules/gui/qt4/components/playlist/standardpanel.cpp
> +++ b/modules/gui/qt4/components/playlist/standardpanel.cpp
> @@ -309,7 +309,7 @@ void StandardPLPanel::popupExplore()
>      char *path = NULL;
> 
>      if( ! uri.isEmpty() )
> -        path = make_path( uri.toStdString().c_str() );
> +        path = make_path( uri.toAscii().constData() );

Are you sure the scope of the result of constData() is long enough? This looks 
like use-after-free to me.

> 
>      if( path == NULL )
>          return;
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> http://mailman.videolan.org/listinfo/vlc-commits


-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis