[vlc-devel] [PATCH]: added proper alignments for arm_neon

Rafaël Carré funman at videolan.org
Thu Jul 26 15:55:23 CEST 2012


Le 2012-07-26 15:54, Rémi Denis-Courmont a écrit :
> Le jeudi 26 juillet 2012 16:46:46 Rafaël Carré, vous avez écrit :
>> Le 2012-07-26 15:08, Felix Paul Kühne a écrit :
>>> Hello,
>>>
>>> the attached patch fixes alignment issues (and crashes) in our NEON code
>>> for iOS. Basically, I'm just following Måns' suggestions for x264 from
>>> earlier this year:
>>> http://mailman.videolan.org/pipermail/x264-devel/2012-January/009068.htm
>>> l
>>
>> It's weird, but here is Måns' commit in x264:
>> http://mailman.videolan.org/pipermail/x264-devel/2012-January/009073.html
> 
> Why weird? http://sourceware.org/binutils/docs/as/Align.html#Align

Weird that it is needed at all

> 
> To me, it looks correct, except for probably breaking compatibility with ARM 
> syntax.

Since gcc supports it we should be good



More information about the vlc-devel mailing list