[vlc-devel] [PATCH 2/3] Save album art to id3 tag.

Rafaël Carré funman at videolan.org
Sun Jul 29 17:29:27 CEST 2012


Le 2012-07-29 13:00, Angelo Haller a écrit :
> On 07/28/2012 04:48 PM, Rafaël Carré wrote:
>> Hello, a few small remarks:
>>
>> Le 2012-07-28 16:39, vlc-devel at szanni.org a écrit :
>>                       ^^^^^^^^^^^^^^^^^^^^
>> Can you check your git setup to add your name?
> Done. My bad.
> 
>> Please use vlc_fopen() and similar which work on all OS (see vlc_fs.h
>> header).
>>
> Thanks, I'll change that.
> I got a little confused though while grep'ing through the source tree.
> There seem to be a few places where plain fopen is used, but maybe
> these are appropriate in those places?

I think fopen is used when the code doesn't run on Windows, vlc_open
handles unicode filenames properly (you can check the implementation(s)
in src/ directory)



More information about the vlc-devel mailing list