[vlc-devel] [PATCH 2/3] Save album art to id3 tag.
funman at videolan.org
Sun Jul 29 17:31:39 CEST 2012
Le 2012-07-29 13:09, Angelo Haller a écrit :
> On 07/28/2012 11:11 PM, Rémi Denis-Courmont wrote:
>> Le samedi 28 juillet 2012 23:56:21 Jean-Baptiste Kempf, vous avez écrit :
>>> On Sat, Jul 28, 2012 at 04:39:35PM +0200, vlc-devel at szanni.org wrote :
>>>> + long l_read = fread( p_buffer, 1, l_buffer, p_file );
>>> Are you sure that fread returns long?
>> It returns ssize_t.
> Just looked at the c99 iso draft that states size_t. That wouldn't be
> anymore, right?
> Just call it something like buffer_size?
Yes, it seems fine.
> On another note: is there a naming policy for resubmitting fixed patches?
Not really.. feel free to use patchset V2 in comment or if you prefer
send individual patches in reply to those.
Personally I prefer to resend the whole patchset so we don't need to
look for the previous patches.
More information about the vlc-devel