[vlc-devel] [PATCH 2/3] Save album art to id3 tag.

Angelo Haller vlc-devel at szanni.org
Tue Jul 31 16:36:30 CEST 2012


On 07/30/2012 02:54 PM, Rémi Denis-Courmont wrote:
> Le dimanche 29 juillet 2012 19:31:21 Angelo Haller, vous avez écrit :
>>> If you really need to know the size of a file, use fstat() please.
>> Any rationale for that? Just curious.
> Because it's semantically correct?
> I don't understand your question.
>
Yes fstat is the correct way of doing things.

I guess the answer I was looking for was (from iso c99 std):
> Setting the file position indicator to end-of-file, as with
> fseek(file, 0, SEEK_END), has undefined behavior for a
> binary stream (because of possible trailing null characters)
> or for any stream with state-dependent encoding that does
> not assuredly end in the initial shift state.
I wasn't aware of that, so thanks for correcting me ;)



More information about the vlc-devel mailing list