[vlc-devel] [PATCH 2/3] Save album art to id3 tag.

[Rémi Denis-Courmont]

Le mardi 31 juillet 2012 17:22:52 Angelo Haller, vous avez écrit :
> On 07/31/2012 02:32 PM, Jean-Baptiste Kempf wrote:
> > On Tue, Jul 31, 2012 at 02:34:03PM +0200, Angelo Haller wrote :
> >> +    long l_buffer = st.st_size;
> > 
> > Sure that st_size is long and not off_t ?
> > 
> > Best regards,
> 
> You're right. Fixed version attached.

It's not that simple. It won't work correctly if the file is Large.

In fact, I think you should put a fixed sane limit on the file size.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis