[vlc-devel] [PATCH] contrib: Fix ARMv6 compilation

[Måns Rullgård]

Edward Wang <edward.c.wang at compdigitec.com> writes:

> The contrib flags got messed up in
> d61052a0987d751ecda0b763c900f834f3358612. This led to VFP instructions
> being used on non-NEON devices, 

Most ARMv6 devices have VFP, so that should not be a problem.  Which
exact chip are you using?

>  contrib/src/main.mak |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> index efdc426..5bb45ab 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -111,7 +111,7 @@ ifdef HAVE_TEGRA2
>      ANDROID_CPU_FLAGS = -mfpu=vfpv3-d16 -mcpu=cortex-a9
>  else
>      ANDROID_ABI = armeabi
> -    ANDROID_CPU_FLAGS = -mcpu=arm1136jf-s -mfpu=vfp
> +    ANDROID_CPU_FLAGS = -march=armv6j -mtune=arm1136j-s -msoft-float

This disables hardware floating-point for all ARMv6 targets.  If there
really exist devices out there without VFP, we should add another
configuration for those, not disable VFP entirely.

-- 
Måns Rullgård
mans at mansr.com