[vlc-devel] [PATCH] libvlc: Wrong behavior: when video is cropped, the output keeps height

Mario Speiß 1034-135 at online.de
Fri Jun 15 23:18:52 CEST 2012


When a video output is cropped (with "crop-top"/"crop-bottom") the video keeps
its current height and gets scaled to fit the original height. This seems to
be a bug, as osys->fit_window gets set to "1" at two lines and to "-1" at
another place but checked against "-1" only. This patch resolves this issue.

Regards,
Mario
---
 src/video_output/display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/video_output/display.c b/src/video_output/display.c
index 50599d0..ebdc0cf 100644
--- a/src/video_output/display.c
+++ b/src/video_output/display.c
@@ -824,7 +824,7 @@ void vout_ManageDisplay(vout_display_t *vd, bool allow_reset_pictures)
             !osys->ch_crop) {
 
             if (!osys->cfg.is_fullscreen && osys->fit_window != 0) {
-                VoutDisplayFitWindow(vd, osys->fit_window == -1);
+                VoutDisplayFitWindow(vd, osys->fit_window != 0);
                 osys->fit_window = 0;
                 continue;
             }
-- 
1.7.5.4




More information about the vlc-devel mailing list