[vlc-devel] [PATCH] HLS: don't signal dl thread out of the blue in Close()

Rémi Denis-Courmont remi at remlab.net
Thu Jun 28 12:22:16 CEST 2012


On Wed, 27 Jun 2012 20:55:15 +0200, Jean-Baptiste Kempf <jb at videolan.org>
wrote:
> I think some of those good advice should be on the wiki, on the
> check-before-sending-for-review page.

The VLC threading subsystem has (always) been modeled after POSIX threads.
There is no point in writing duplicated sub-standard VLC-specific
documentation for those generic C programming paradigms. Indeed, any
programmer familiar with POSIX threads should be able to use VLC threads
easily. Conversely, any programmer unfamiliar with threading can be
referred to generic POSIX threads quality documentation (e.g. books), to
learn to program not only for VLC but for many other C projects.

Furthermore, reference to an external standard provides a sane
specification for what the semantics should be. Some VLC-specific helper
functions have been plagged with vague definitions and changing semantics
across versions and developers (e.g. string processing): I want to avoid
that problem whenever possible.

-- 
Rémi Denis-Courmont
Sent from my collocated server



More information about the vlc-devel mailing list