[vlc-devel] [PATCH] HLS: don't signal dl thread out of the blue in Close()

Rémi Denis-Courmont remi at remlab.net
Thu Jun 28 13:19:23 CEST 2012

On Thu, 28 Jun 2012 13:08:44 +0200, Frederic YHUEL <fyhuel at viotech.net>
> However, maybe it would be wise to warn people that some modules in
> VLC don't use threads properly. For exemple, we can find the following
> pattern in a few modules:

It would be wise to warn people that the code base has bugs? Yeah sure.
But how do you actually do that?

> audio_output/auhal.c
> access_output/rtmp.c
> media_library/ml_watch.c
> access/rtmp/rtmp_amf_flv.c
> access/rtmp/access.c

All but auhal are disabled.

I'd argue RTMP and ML should be removed, since they are more likely to be
rewritten from scratch than fixed, at this point.

> This is very cool. And with C99?

There is no memory model in C99, since there is no multi-threading in C99.

Rémi Denis-Courmont
Sent from my collocated server

More information about the vlc-devel mailing list