[vlc-devel] [vlc-commits] MMS: add an error message if UTF-16 conversion fails

[Rémi Denis-Courmont]

Le samedi 3 mars 2012 19:37:52 Rafaël Carré, vous avez écrit :
> "Rémi Denis-Courmont" <remi at remlab.net> wrote:
> > Le samedi 3 mars 2012 02:09:53 Rafaël Carré, vous avez écrit :
> > > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Fri Mar  2
> > > 19:08:48 2012 -0500| [26db27e01ad310bfc9004ce6fa22e40a3892fbd5] |
> > > committer: Rafaël Carré
> > > 
> > > MMS: add an error message if UTF-16 conversion fails
> > 
> > UTF-16 conversion cannot fail unless the input is not valid or memory is
> > out, so that does not seem like the right place to check.
> 
> Or if iconv() fails internally (e.g. if it's just a stub)

iconv is (one of the few) mandatory requirements of VLC.

> > > Server rejects connection if some field are not set properly
> > 
> > I don't see how that fixes the problem.
> 
> It's not a fix but a debugging help, I've seen the problem occur 2
> times already, so it should make it explicit in the log why the server
> rejects our connection attempt.

Adding a parameter to a function just to print a debug message that is not 
supposed to happen... well...

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis