[vlc-devel] [vlc-commits] input_EsOutNew: use calloc
funman at videolan.org
Mon Mar 5 11:54:39 CET 2012
Le 05/03/2012 05:16, Rémi Denis-Courmont a écrit :
> On Mon, 05 Mar 2012 05:00:27 -0500, Rafaël Carré <funman at videolan.org>
>> Le 05/03/2012 04:57, Rémi Denis-Courmont a écrit :
>>> On Mon, 5 Mar 2012 10:36:40 +0100 (CET), git at videolan.org (Rafaël
>>>> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Mon Mar 5
>>>> 02:16:50 2012 -0500| [6eeeda913c22e1fd32107bf12bf2c7df6c2938fc] |
>>>> committer: Rafaël Carré
>>>> input_EsOutNew: use calloc
>>> Why? This uselessly initializes stuff that was initialized to non-zero.
>> Agreed but this makes it easier to read IMO.
> I disagree. It hides the initializations behind the allocation. That's
> harder to read.
That trick is used several times in the codebase already.
Is there any reason your comment applies to this file in particular?
More information about the vlc-devel