[vlc-devel] [PATCH] dash: read skips bytes when p_read is NULL

[Frederic YHUEL]

On Tue, Mar 6, 2012 at 11:14 AM, Hugo Beauzée-Luyssen
<beauze.h at gmail.com> wrote:
> On Tue, Mar 6, 2012 at 8:30 AM,  <Christopher at mailsrv.uni-klu.ac.at> wrote:
>> From: Christopher Mueller <christopher.mueller at itec.aau.at>
>>
>> ---
>>  modules/stream_filter/dash/buffer/BlockBuffer.cpp |    6 +++++-
>>  1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/modules/stream_filter/dash/buffer/BlockBuffer.cpp b/modules/stream_filter/dash/buffer/BlockBuffer.cpp
>> index 2b10358..056c481 100644
>> --- a/modules/stream_filter/dash/buffer/BlockBuffer.cpp
>> +++ b/modules/stream_filter/dash/buffer/BlockBuffer.cpp
>> @@ -103,7 +103,11 @@ int     BlockBuffer::get                  (void *p_data, unsigned int len)
>>
>>     this->reduceBufferMilliSec(ret);
>>
>> -    block_GetBytes(&this->buffer, (uint8_t *)p_data, ret);
>> +    if(p_data == NULL)
>> +        block_SkipBytes(&this->buffer, ret);
>> +    else
>> +        block_GetBytes(&this->buffer, (uint8_t *)p_data, ret);
>> +
>>     block_BytestreamFlush(&this->buffer);
>>     this->notify();
>>
>> --
>> 1.7.0.4
>>
>
> Applied, thanks!
>

Could you guys also implement Seek() in DASH module? I guess it should
be quite easy for you, now that the internal buffer is here.

If you don't want to do it or don't have enough time, tell me, I'll try.

Best Regards,

-- 
Frédéric