[vlc-devel] [vlc-commits] Audio: Core Audio: Initialize starting volume for analog devices.

[Felix Paul Kühne]

On 07.03.2012, at 13:19, Rémi Denis-Courmont wrote:

> On Wed,  7 Mar 2012 12:49:48 +0100 (CET), git at videolan.org (Jon Stacey)
> wrote:
>> vlc | branch: master | Jon Stacey <jon at jonsview.com> | Wed Mar  7
> 01:25:26
>> 2012 -0600| [29f33902b603620342bd5420f46dddfc41ae0ddf] | committer:
> Felix
>> Paul Kühne
>> 
>> Audio: Core Audio: Initialize starting volume for analog devices.
>> 
>> Signed-off-by: Felix Paul Kühne <fkuehne at videolan.org>
> 
> Don't count on me to review MacOS audio patches from now on.

Sorry, is this commit so obviously flawed?

Let me elaborate the problem:
After introducing aout_VolumeHardInit, the audio module didn't respond to the current volume setting properly anymore in a few circumstances, namely: you mute the volume after launch and start an input. The input will play at the last volume level prior to muting. This also applies to volume settings other than mute.
Thus, reading the volume value directly after initializing the module makes perfect sense to me, so please give me feedback why you do think this is wrong.

Thanks!

Felix