[vlc-devel] [PATCH] karaoke : setting the output to mono

[Rémi Denis-Courmont]

Le mercredi 7 mars 2012 01:51:10 Sukrit Sangwan, vous avez écrit :
> diff --git a/modules/audio_filter/karaoke.c
> b/modules/audio_filter/karaoke.c index 81bc276..609f365 100644
> --- a/modules/audio_filter/karaoke.c
> +++ b/modules/audio_filter/karaoke.c
> @@ -58,6 +58,8 @@ static int Open (vlc_object_t *obj)
>      }
> 
>      filter->pf_audio_filter = Process;
> +    filter->fmt_out.audio.i_physical_channels = AOUT_CHAN_CENTER;
> +    filter->fmt_out.audio.i_channels = 1;

Eh you cannot do that. First it leaves some fields in the format in 
inconsistent state. Second, I'm not sure how the core behaves if a filter 
changes the format... ? Otherwise, I wouldn't have written the code with that 
TODO.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis