[vlc-devel] [vlc-commits] Audio: Core Audio: Initialize starting volume for analog devices.
jon at jonsview.com
Wed Mar 7 21:04:20 CET 2012
Rémi, did we get our wires crossed? I think you were referring to patch 0052 which changed aout_HardVolumeInit(), but Felix committed 0053 which only affects the auhal module. That should have no affect on the operations of other modules. Please clarify exactly which patch you are referring to.
With regards to 0052, I have not been able to find any good information about this in the wiki or the source. I currently do not understand why aout_VolumeSoftInit() sets the default volume, but aout_VolumeHardInit() does not. It seems like these should have the same behavior, so I'm probably missing something. Can you provide a link to the non-source documentation you wrote?
I've also been looking through the pulse source and the only place that I have seen the volume initialized is in sink_input_info_cb(). This seems strange to me because the PulseAudio documentation says that pa_context_get_sink_input_info() is only supposed to "Get some information about a sink input by its index." It does not seem like the volume should be initialized here, but that's just me. Nonetheless, patch 0053 initializes the volume within the auhal module itself like the pulse module does, so it shouldn't affect anything else.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel