[vlc-devel] stereo enhancer audio effect

[Jean-Baptiste Kempf]

On Fri, Mar 09, 2012 at 08:48:43AM -0800, Sukrit Sangwan wrote :
> Fixed it. Freed p_sys first and then return VLC_ENOMEM.

Thank you for you work.

>  modules/audio_filter/Modules.am     |    1 +
>  modules/audio_filter/stereo_widen.c |  142 +++++++++++++++++++++++++++++++++++

Missing modules/LIST and NEWS entry.

> +/*****************************************************************************
> + * stereo_widen.c : simple stereo widening effect
> + *****************************************************************************
> + * Copyright (C) the VideoLAN team

Year?

> +#define DELAY       20
> +#define DRY_MIX     0.8
> +#define WET_MIX     0.3
> +#define FEEDBACK    0.3

Are those the same as the spatializer wet and dry?

> +    set_description (N_("Simple Stereo enhancer"))

What does it do?

> +     !AOUT_FMTS_IDENTICAL( &p_filter->fmt_in.audio, &p_filter->fmt_out.audio ))
Weird )) style.


Else,fine for me.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device