[vlc-devel] [PATCH 2/3] Audioscrobbler: Update the scrobbling protocol to the version 2.0.

Ilkka Ollakka ileoo at videolan.org
Sat Mar 10 19:53:03 CET 2012

On Fri, Mar 09, 2012 at 07:28:08PM +0100, Samuel Pitoiset wrote:
> +
> +    /* transmit the request */
> +    int i_net_ret = net_Printf(p_this, i_sock, NULL, psz_request);

This will crash if you have any % in psz_request, for example url
encoded space in artist. I noticed it when patch crashed on me and
courmisch pointed out that if used like this it should be %-free. So you
should use net_Printf(p_this, i_sock, NULL, "%s", psz_request);

Other than that, I don't see any big issues atm.

Ilkka Ollakka
You should never wear your best trousers when you go out to fight for
freedom and liberty.
		-- Henrik Ibsen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120310/e0e4f872/attachment.sig>

More information about the vlc-devel mailing list