[vlc-devel] stereo enhancer audio effect

[Jean-Baptiste Kempf]

On Sat, Mar 10, 2012 at 06:26:10AM -0800, Sukrit Sangwan wrote :
> +#define DELAY       20
> +#define DRY_MIX     0.8
> +#define CROSSFEED   0.3
> +#define FEEDBACK    0.3

Should, some of those, be configurable?

> +    if ( p_filter->fmt_in.audio.i_format != VLC_CODEC_FL32 ||

> +    if ( p_filter->fmt_in.audio.i_channels != 2 )

> +    if( unlikely(!p_sys) )

> +    if( unlikely(!p_sys->pf_begin) )

Are you using 'if( ' or 'if ( ' ?


> +/*****************************************************************************
> + * Filter: process each sample
> + *****************************************************************************/
> +static block_t *Filter( filter_t *p_filter, block_t *p_block )
> +{
> +    filter_sys_t *p_sys = p_filter->p_sys;
> +    float *p_out = (float *)p_block->p_buffer;
> +    float *pf_read;
> +    

trailing spaces.

Seems ok to me.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device