[vlc-devel] libvlc_video_set_format_callbacks() and "cyuv" chroma

[Rafaël Carré]

Le 2012-03-10 19:46, Jérôme FORISSIER a écrit :
> 
> On 10 mars 2012, at 23:33, Rafaël Carré wrote:
> 
>> Le 09/03/2012 20:17, Jérôme FORISSIER a écrit :
>>>
>>> diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
>>> index 9410d77..15d452c 100644
>>> --- a/src/misc/fourcc.c
>>> +++ b/src/misc/fourcc.c
>>> @@ -1498,7 +1498,8 @@ const char *vlc_fourcc_GetDescription( int i_cat, vlc_fourcc_t i_fourcc )
>>>
>>> #define VLC_CODEC_YUV_PACKED \
>>>     VLC_CODEC_YUYV, VLC_CODEC_YVYU, \
>>> -    VLC_CODEC_UYVY, VLC_CODEC_VYUY
>>> +    VLC_CODEC_UYVY, VLC_CODEC_VYUY, \
>>> +    VLC_CODEC_CYUV
>>>
>>> #define VLC_CODEC_FALLBACK_420 \
>>>     VLC_CODEC_YUV_PLANAR_422, VLC_CODEC_YUV_PACKED, \
>>
>> Isn't CYUV missing from a few fallback lists?
> 
> That's quite possible, but unfortunately I don't understand this code well enough to propose a patch.

I think the lists hold similar formats for cheap video output conversion.

e.g. if you decode to UYVY, the video output will first try to use UYVY,
then similar formats where conversion is easy (see modules/video_output/*)

Actually I don't think CYUV is a popular format for video outputs, so it
could be either absent or down in the list.

Perhaps more important is a list of fallbacks for CYUV video.


I agree that this file is weird :)