[vlc-devel] [PATCH] check for crazy values in rtsp npt range

Rémi Denis-Courmont remi at remlab.net
Mon Mar 12 17:20:16 CET 2012

Le lundi 12 mars 2012 18:06:28 Sébastien Escudier, vous avez écrit :
> Hi,
> I would like to know if this patch is OK.

Since we use fast-math, rounding out-of-range values is undefined. So in 
principles, we really should always do this when an overflow is possible. It 
would arguably be worse if we did not use fast-math. Then the well defined 
behaviour would raise a floating point exception, which of course we do not 

But I am not sure if your code works properly even if the rounded value is 
close to the limit. I hope someone has better clue about FP than I do.

Also maybe a more systematic search in demuxers should be done?

Rémi Denis-Courmont

More information about the vlc-devel mailing list