[vlc-devel] [PATCH] fix ogg muxer structure packing

[Rémi Denis-Courmont]

On Wed, 14 Mar 2012 11:44:00 +0100, Sébastien Escudier
<sebastien-devel at celeos.eu> wrote:
> Hi,
> 
> I found that ogm muxing is broken on windows due to struct padding.
> This patch fixes it, but is it a correct way to do it ?
> If not, how ?

Binary file layouts should not be structures, unless maybe:
1) The structure is only used as a data or cache file for VLC on the local
system.
2) Every field of the structure is aligned on its natural boundary
(16-bits, 32-bits, 64-bits) and the whole structure size is a multiple of
64-bits.

Otherwise it _will_ break on some architectures.

-- 
Rémi Denis-Courmont
Sent from my collocated server