[vlc-devel] [PATCH] Support disc drives probing for OS/2

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> Le dimanche 11 mars 2012 05:06:39 Rafaël Carré, vous avez écrit :
>> Le 2012-03-03 12:27, Rémi Denis-Courmont a écrit :
>>> I'm always playing the same song, but that stuff belongs in
>>> modules/services_discovery, where other interfaces and other application
>>> can also access it.
>>
>> That code is not only redundant but buggy:
>>
>> On Windows: drives are listed multiple times.
> 
>> On Linux: I have 13 entries while I only have 2 drives, one of them with
>> a media yet I can't tell which one it is from that list.
> 
> On Linux, the SD is a lot better than the overly simplistic Qt4 file pattern 
> matching.
> 
> TBH, the Windows disc service discovery lists empty drives too. And it 
> probably fails with disc formats that do not support file://. So it is only 
> marginally better than the Qt4 implementation.
> 
>> So I want remove the code from Qt4.
> 
> Unfortunately, there are no easy way to access a SD outside the playlist 
> model. That is where I got stuck, as I cannot convince JB to completeley 
> remove the disc opening dialog.
> 
>> If you want to control menu presence, starting chapter, title or
>> whatnot, I guess you're able to fill in a device path.
> 
> I agree and I suggested the same in a much earlier discussion. But there was 
> no agreement.
> 
> 
> The same problem affects video, screen and audio capture.
> 

If so, this patch cannot be accepted ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr