[vlc-devel] [PATCH] Vovoid VSXu audio visualization integration

[Jean-Baptiste Kempf]

On Wed, Mar 14, 2012 at 12:53:57PM +0100, Jonatan Wallmander wrote :
> +  [  --enable-vsxu           Vovoid VSXu visualization plugin (default enabled)])

It seems "default auto" to me
> +  ])
> +
> +
> +
> +dnl

One less line, please.

> +SOURCES_vsxu = vsxu.cpp\
> +               cyclic_buffer.h

You can put that on one line, you know.

> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the Free
> + * Software Foundation; either version 2 of the License, or (at your option)
> + * any later version.

Could you relicese this to LGPL?

> diff --git a/modules/visualization/projectm.cpp b/modules/visualization/projectm.cpp
> index c21ecb6..0e6c3a8 100644
> --- a/modules/visualization/projectm.cpp
> +++ b/modules/visualization/projectm.cpp
> @@ -177,7 +177,7 @@ static int Open( vlc_object_t * p_this )
>      p_filter->pf_audio_filter = DoWork;
>  
>      p_sys = p_filter->p_sys = (filter_sys_t*)malloc( sizeof( *p_sys ) );
> -    if( !p_sys )
> +    if( unlikely( !p_sys ) )
>          return VLC_ENOMEM;


This is for another patch, please.

> +#define CONFIG_TEXT N_("vsxu share path")
> +#define CONFIG_LONGTEXT N_("Path to vsxu data folder")

Useless

> +    int i_channels;
> +    bool         b_error;
> +    bool  b_quit;
> +    bool first;

Weird alignment

> +    // --- 1 byte hole

Remove this.

> +    p_filter->pf_audio_filter = DoWork;

Move that toward the end of init, please.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device