[vlc-devel] [vlc-commits] MMS: fix Stack overflow

Laurent Aimar fenrir at elivagar.org
Thu Mar 15 15:09:36 CET 2012


On Thu, Mar 15, 2012 at 02:53:30PM +0100, Jean-Baptiste Kempf wrote:
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Tue Mar 13 11:21:27 2012 +0100| [3a57afee14a7f00fd6ff0cccb90a60923ccf766d] | committer: Jean-Baptiste Kempf
> 
> MMS: fix Stack overflow
> +    char         *tmp;
>      uint16_t     *p;
>      int          i_server_version;
>      int          i_tool_version;
> @@ -532,11 +532,18 @@ static int MMSOpen( access_t  *p_access, vlc_url_t *p_url, int  i_proto )
>      var_buffer_initwrite( &buffer, 0 );
>      var_buffer_add16( &buffer, 0x001c );
>      var_buffer_add16( &buffer, 0x0003 );
> -    sprintf( tmp,
> +    if( asprintf( tmp,
 &tmp no ? (same for the following ones).

-- 
fenrir




More information about the vlc-devel mailing list