[vlc-devel] [PATCH 1/3] text: make_path returns (null) if hostname starts with blank

[John Freed]

This is indeed the one I am most concerned about. One possibility to reduce
the potential impact would be to move the condition down a few lines so it
affects only Win32 users, though in theory a URI constructed as "file:// /"
with a space after the double-slash should always return null.

My concern is that this is used in at least some parts of the code as a
quick-and-dirty method. I'm fine if it's not applied at all. It is,
however, what put me on the trail of this to begin with -- when I noticed
the different behavior under Win32 and Linux.


On Fri, Mar 16, 2012 at 9:50 AM, <vlc-devel-request at videolan.org> wrote:

> ------------------------------
>
> Message: 2
> Date: Fri, 16 Mar 2012 10:38:03 +0200
> From: " R?mi Denis-Courmont" <remi at remlab.net>
> To: vlc-devel at videolan.org
> Subject: Re: [vlc-devel] [PATCH 1/3] text: make_path returns (null) if
>        hostname starts with blank
> Message-ID: <201203161038.06327.remi at remlab.net>
> Content-Type: Text/Plain;  charset="iso-8859-1"
>
> Le jeudi 15 mars 2012 22:54:27 John Freed, vous avez ?crit :
> > This makes Win32 conform to Linux behavior, as well as RFCs. Valid UNC
> > paths still work.
>
> I think this deserves a new test case in src/test/url.c.
>
> --
> R?mi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120316/948ab274/attachment.html>