[vlc-devel] [PATCH 0/3] win32 BDA patches

[John Freed]

You can test the dshow part separately; please let me know how it
turns out. This was a maddening situation that took a long time to
figure out. Here is the Win32 (under XP and Win7) behavior I found:

Case 1
- Create a filter by binding moniker
- set to NULL -- crash, as expected [note, I didn't test doing a
Release() on the filter at this point but expect it would succeed]

Case 2
- Create filter
- AddFilter to graph
- RemoveFilter from graph
- Release filter -- crash, not expected

Case 3
- Create filter
- AddFilter to graph
- RemoveFilter from graph
- set to NULL -- no problem

Fortunately it was 100% reproducible.

This behavior was not at all what I expected, and I don't see any
documentation of it in MSDN, though this whole area is poorly
documented.


> Message: 10
> Date: Fri, 16 Mar 2012 09:10:04 +0200
> From: Kaarlo R?ih? <kaarlo.raiha at gmail.com>
> To: Mailing list for VLC media player developers
>        <vlc-devel at videolan.org>
> Subject: Re: [vlc-devel] [PATCH 0/3] win32 BDA patches
> Message-ID:
>        <CAMKrNtx3HKY0ohYSUXYJ_Wwhu7F1sSgfrRs40agp=s7KCjrTrg at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> 16. maaliskuuta 2012 0.56 Jean-Baptiste Kempf <jb at videolan.org> kirjoitti:
>
>> On Thu, Mar 15, 2012 at 09:54:25PM +0100, John Freed wrote :
>> > John Freed (3):
>> >   dshow: Remove filters but don't Release() them
>> >   dtv: Thorough rewrite of BDA graph for Win32
>>
>> Is anyone able to review those 2 patches?
>> Or should we apply and wait for tester feedback?
>>
>
> +1 for applying since AFAIK BDA doesn't work in current releases. And I can
> test dshow part that way easier.
>
>
>>
>> Best regards,
>>
>> --
>> Jean-Baptiste Kempf
>> http://www.jbkempf.com/ - +33 672 704 734
>> Sent from my Electronic Device