[vlc-devel] [PATCH 1/3] text: make_path returns (null) if hostname starts with blank

[John Freed]

As this is very deep in the code, so far as I can tell, I would
suggest not applying it till it is thoroughly vetted -- whether Win32
only or generally.

It is a simple patch but could have a variety of unexpected side
effects, if other parts of the (Win32) code are depending on
nonstandard behavior.

I believe the non-Win32 code permits only "localhost" (or null) as a
valid hostname and returns null for *all* other hostnames. Since only
Win32 tries to process other hostnames, perhaps it's best to put the
exception there, if at all.


On Fri, Mar 16, 2012 at 10:31 AM,  <vlc-devel-request at videolan.org> wrote:
>
> ------------------------------
>
> Message: 3
> Date: Fri, 16 Mar 2012 11:06:48 +0200
> From: " R?mi Denis-Courmont" <remi at remlab.net>
> To: vlc-devel at videolan.org
> Subject: Re: [vlc-devel] [PATCH 1/3] text: make_path returns (null) if
>        hostname starts with blank
> Message-ID: <201203161106.48789.remi at remlab.net>
> Content-Type: Text/Plain;  charset="iso-8859-15"
>
> Le vendredi 16 mars 2012 10:57:05 John Freed, vous avez ?crit :
>> This is indeed the one I am most concerned about. One possibility to reduce
>> the potential impact would be to move the condition down a few lines so it
>> affects only Win32 users, though in theory a URI constructed as "file:// /"
>> with a space after the double-slash should always return null.
>
> Fine with me either way. But if it modifies non-Win32, it needs a test case.
>
> --
> R?mi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
>
>