[vlc-devel] [PATCH 3/3] dtv: Thorough rewrite of BDA graph for Win32

Rémi Denis-Courmont remi at remlab.net
Fri Mar 16 11:13:31 CET 2012


+    if( clsid == CLSID_NetworkProvider )
+        sys = UNIVERSAL;

I don't see what that is supposed to mean. Whether this is a DVB-IP receiver, 
a remote DVB tuner or an externally configured tuner, it definitely won't 
accept every possible standard. Claiming the contrary will ruin the frequency 
scanner.

Note that the common code already supports receiving without tuning. If no 
frequency is specified, VLC will directly try to receive the stream, assuming 
something else takes care of tuning.

+    msg_Dbg( p_access, "EnumSystems: Entering EnumSystems 0314 10:45pm" );

This is rather peculiar.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list