[vlc-devel] [PATCH] Vovoid VSXu audio visualization integration

[Rémi Denis-Courmont]

Le vendredi 16 mars 2012 22:52:47 Jonatan Wallmander, vous avez écrit :
> On 03/16/2012 09:58 AM, Rémi Denis-Courmont wrote:
> > A few variables in p_sys could probably be local to the thread function.
> > Also I think putting the thread cleanup code in place of abort() would
> > be more legible.
> > 
> > But I have no functional objections.
> 
> Here is a new patch. I have fixed up a lot of stuff and cleaned up the
> code.. A whole bunch of unnecessary variables were removed and the flow
> should be easier to read now.

Right.

You don't need to call vlc_savecancel(), since you never call vlc_cancel().

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis