[vlc-devel] [PATCH 2/3] dshow: Remove filters but don't Release() them

[Rémi Denis-Courmont]

   Hello,

On Sun, 18 Mar 2012 22:29:28 +0100, John Freed <okvlc at johnfreed.com>
wrote:
>      /* Release objects */
> -    p_device_filter->Release();
> -    p_capture_filter->Release();
> +    /* RemoveFilter does an undocumented Release()
> +     * but does not set item to NULL*/
> +
> +    p_device_filter = NULL;
> +    p_capture_filter = NULL;

What's the point in setting automatic variables before return?

>  
>      return VLC_EGENERIC;
>  }

-- 
Rémi Denis-Courmont
Sent from my collocated server