[vlc-devel] [PATCH 2/3] dshow: Remove filters but don't Release() them

[John Freed]

I don't know the original thinking; this is very old code. Git blame says:

6ee0c084 (Gildas Bazin         2003-08-25 21:45:04

In any event, should that error condition ever occur, VLC will crash
rather than gracefully complain, I believe, because of the Release().

>
>
> Date: Mon, 19 Mar 2012 08:40:53 +0100
> From: R?mi Denis-Courmont <remi at remlab.net>
> To: Mailing list for VLC media player developers
>        <vlc-devel at videolan.org>
> Subject: Re: [vlc-devel] [PATCH 2/3] dshow: Remove filters but don't
>        Release() them
> Message-ID: <ae66c7f2de83a31f1536dc3a1ea3c7ee at chewa.net>
> Content-Type: text/plain; charset=UTF-8
>
>   Hello,
>
> On Sun, 18 Mar 2012 22:29:28 +0100, John Freed <okvlc at johnfreed.com>
> wrote:
> >      /* Release objects */
> > -    p_device_filter->Release();
> > -    p_capture_filter->Release();
> > +    /* RemoveFilter does an undocumented Release()
> > +     * but does not set item to NULL*/
> > +
> > +    p_device_filter = NULL;
> > +    p_capture_filter = NULL;
>
> What's the point in setting automatic variables before return?
>
> >
> >      return VLC_EGENERIC;
> >  }
>