[vlc-devel] [vlc-commits] vlc: assume UTF-8 and drop dependency on libvlccore

[Ilkka Ollakka]

On Mon, Mar 19, 2012 at 09:24:18PM +0100, Rémi Denis-Courmont wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Mar 19 20:54:12 2012 +0200| [ae7b55a4f9db27c0117666d8f3c32fbd9dc5eb31] | committer: Rémi Denis-Courmont

> vlc: assume UTF-8 and drop dependency on libvlccore

> -    int i = 1;
> -#ifdef __APPLE__
> -    /* When VLC.app is run by double clicking in Mac OS X, the 2nd arg
> -     * is the PSN - process serial number (a unique PID-ish thingie)
> -     * still ok for real Darwin & when run from command line
> -     * for example -psn_0_9306113 */
> -    if(i_argc >= 2 && !strncmp( ppsz_argv[1] , "-psn" , 4 ))
> -        i = 2;
> -#endif
> -    for (; i < i_argc; i++)
> -        if ((argv[argc++] = FromLocale (ppsz_argv[i])) == NULL)
> -            return 1; // BOOM!
>      argv[argc] = NULL;

I think you forgot to move ppsz_argv into argv here, vlc now ignores all
commandline options

-- 
Ilkka Ollakka
Every solution breeds new problems.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120320/acb33d8b/attachment.sig>