[vlc-devel] [PATCH] npapi plugin slave-input support Add the ability to specify a sound source through slave-input, for example a v4l video capture device with alsa audio.

[Tord Andersson]

Sergey,

I have now resubmitted the npapi plugin slave-input patch with added buffer overflow correction.
Hope it will work better this time!
Thanks for your feedback!

Best regards,

Tord Andersson

On 2012-03-16 16.18, Sergey Radionov wrote:
> 2012/3/16 Tord Andersson <tord.andersson at endian.se>:
>> ---
>>  npapi/vlcplugin_base.cpp |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/npapi/vlcplugin_base.cpp b/npapi/vlcplugin_base.cpp
>> index 1d9db49..bc6d0c1 100644
>> --- a/npapi/vlcplugin_base.cpp
>> +++ b/npapi/vlcplugin_base.cpp
>> @@ -464,6 +464,12 @@ NPError VlcPluginBase::init(int argc, char* const argn[], char* const argv[])
>>         {
>>             set_enable_fs( boolValue(argv[i]) );
>>         }
>> +        else if( !strcmp( argn[i], "input-slave" ) )
>> +        {
>> +            char psz_input_slave_opts[80] = "--input-slave=";
>> +            strcat(psz_input_slave_opts, argv[i]);
> what if argv[i] will be longer than 66 chars? buffer overflow?
>> +            ppsz_argv[ppsz_argc++] = psz_input_slave_opts;
>> +        }
>>         else if( !strcmp( argn[i], "mute" ) )
>>         {
>>             if( boolValue(argv[i]) )
>> --
>> 1.7.5.4
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel


-- 
Tord Andersson
Endian Technologies AB

phone:  +46 (0)31 706 06 00
mobile: +46 (0)767 73 40 14
mail:   tord.andersson at endian.se
pgp:    F934 1A9B 5E2D 0563 49FE B8EB 0F53 851B E1FA 3E8B