[vlc-devel] [PATCH 0/2] fixes for 1.1

Ilkka Ollakka ileoo at videolan.org
Wed Mar 21 12:24:57 CET 2012


On Wed, Mar 21, 2012 at 12:13:50PM +0100, John Freed wrote:
> resubmitting fix of memory leak in oldhttp and adding album art

> newly submitting backport of RemoveFilter fix from 2.0

> John Freed (2):
>   oldhttp album art
>   bda: RemoveFilter does an undocumented Release but does not set
>     filter to NULL.

>  modules/access/mms/mmstu.c                    |   34 ++++++--
>  modules/access/rtsp/real.c                    |    7 +-
>  modules/audio_filter/converter/a52tofloat32.c |   64 +++++-----------
>  modules/audio_filter/converter/dtstofloat32.c |   56 ++++----------
>  modules/demux/ty.c                            |    2 +-
>  modules/meta_engine/id3genres.h               |  104 +++++++++++++++++++++----
>  modules/misc/lua/libs/input.c                 |    2 +-
>  src/input/input.c                             |    3 +-
>  src/text/unicode.c                            |    2 +-

Don't think those changes should be in patches named like that. Instead
it should be separated patch (or multiple patches).

-- 
Ilkka Ollakka
The cost of living is going up, and the chance of living is going
down.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120321/d807ca67/attachment.sig>


More information about the vlc-devel mailing list