[vlc-devel] [vlc-commits] Revert "contrib: ffmpeg: add some cflags for arm/neon"

Jean-Baptiste Kempf jb at videolan.org
Wed Mar 21 17:38:11 CET 2012


On Wed, Mar 21, 2012 at 06:00:07PM +0200, Rémi Denis-Courmont wrote :
> I undid the revert because HAVE_NEON is Android-specific. But there is 
> something seriously wrong with the naming here.

Indeed. NEON exists on so many OSes.

> Also selecting a specific CPU in flags does not seem like a very good idea. 

-mtune should be more appropriate, IMVHO.

> And I see no reasons why this should be FFmpeg-specific either.

Because, I think, that Mans did advise to use -mcpu when compiling
FFmpeg. But this does not belong to contrib/src/ffmpeg/rules.mak, if I
may say so.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list