[vlc-devel] fixes for 1.1

[John Freed]

thanks for the feedback.

i'll wait 24 hours for more comments, then will resubmit as two
totally separate patches per ileoo and heed courmisch's advice on the
ASSERT.

On Wed, Mar 21, 2012 at 2:27 PM,  <vlc-devel-request at videolan.org> wrote:
> Message: 1
> Date: Wed, 21 Mar 2012 13:24:57 +0200
> From: Ilkka Ollakka <ileoo at videolan.org>
> To: vlc-devel at videolan.org
> Subject: Re: [vlc-devel] [PATCH 0/2] fixes for 1.1
> Message-ID: <20120321112456.GS32042 at ileoo>
> Content-Type: text/plain; charset="iso-8859-1"
>
> On Wed, Mar 21, 2012 at 12:13:50PM +0100, John Freed wrote:
>> resubmitting fix of memory leak in oldhttp and adding album art
>
>> newly submitting backport of RemoveFilter fix from 2.0
>
>> John Freed (2):
>>   oldhttp album art
>>   bda: RemoveFilter does an undocumented Release but does not set
>>     filter to NULL.
>
>>  modules/access/mms/mmstu.c                    |   34 ++++++--
>>  modules/access/rtsp/real.c                    |    7 +-
>>  modules/audio_filter/converter/a52tofloat32.c |   64 +++++-----------
>>  modules/audio_filter/converter/dtstofloat32.c |   56 ++++----------
>>  modules/demux/ty.c                            |    2 +-
>>  modules/meta_engine/id3genres.h               |  104 +++++++++++++++++++++----
>>  modules/misc/lua/libs/input.c                 |    2 +-
>>  src/input/input.c                             |    3 +-
>>  src/text/unicode.c                            |    2 +-
>
> Don't think those changes should be in patches named like that. Instead
> it should be separated patch (or multiple patches).
>
> --
> Ilkka Ollakka