[vlc-devel] [vlc-commits] macosx: remove volume osd slider code

[Felix Paul Kühne]

On 21.03.2012, at 19:36, David Fuhrmann wrote:

> 
> Am 21.03.2012 um 18:14 schrieb Felix Paul Kühne:
> 
>> On 21.03.2012, at 18:06, David Fuhrmann wrote:
>> 
>>> macosx: remove volume osd slider code
>> 
>> Would it be better to fix the OSD slider instead?
>> 
>> Quite a few people tended to like it in previous releases, including me.
> 
> I'm not really a fan of this slider. But if other users like it we can implement it, of course. But in this case I would suggest to show the slider only if VLC is in fullscreen mode, as it was done in previous versions.
Yes, that would be nice!

> But I still hope that we can find a way to avoid this duplicated code (at least for future major releases)…
Idem. However, I can't suggest a place where to put it.

Opinions?

> 
>> Slightly OT: could you give us a minute between committing and back porting, so we can have a look at the patch first?
> 
> OK. How long should that minute last? :-)

One night sounds reasonable to me. Or until j-b cherry-picks the stuff - whatever happens first ;-)


Best,

Felix