[vlc-devel] [PATCH] libmp4: add TfrfBox and TfxdBox parsing

[Jean-Baptiste Kempf]

On Thu, Mar 22, 2012 at 05:41:36PM +0100, Frédéric Yhuel wrote :
> +static inline int CmpUUID( const UUID_t *u1, const UUID_t *u2 )
> +{
> +    return memcmp( u1, u2, 16 );
> +}

guidcmp, if it is compatible... ( UUID_t vs GUID ?)

> +static int MP4_ReadBox_uuid( stream_t *p_stream, MP4_Box_t *p_box )
> +{
> +    if( !CmpUUID( &p_box->i_uuid, &TfrfBoxUUID ) )
> +        return MP4_ReadBox_tfrf( p_stream, p_box );
> +    if( !CmpUUID( &p_box->i_uuid, &TfxdBoxUUID ) )
> +        return MP4_ReadBox_tfxd( p_stream, p_box );
> +
> +    msg_Warn( p_stream, "Unknown uuid type box" );
> +    return 1;
Why 1 ?

Rest seems ok.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device