[vlc-devel] [PATCH] check for crazy values in rtsp npt range

Rémi Denis-Courmont remi at remlab.net
Sun Mar 25 10:13:52 CEST 2012


On Sun, 25 Mar 2012 09:21:52 +0200, Tobias Güntner <fatbull at web.de> wrote:
> Am 25.03.2012 08:36, schrieb Rémi Denis-Courmont:
>> On Sun, 25 Mar 2012 08:01:35 +0200, Tobias Güntner <fatbull at web.de>
>> wrote:
>>> I'm not sure how to work around this.
feclearexcept/llrint/fetestexcept
>>> perhaps?
>> 
>> Due to -ffast-math, I think math exceptions in VLC code do not work.
>> 
> 
> Hmmm ...
> * Is there another way to check for floating point errors?

I don't think so. Intrinsically, fast-math turns off error checks.

> * Is -ffast-math really required?

Probably for audio filters, yes.

> * Perhaps checking if a value >= INT64_MAX (instead of > INT64_MAX) is
> sufficient?

No clue.

-- 
Rémi Denis-Courmont
Sent from my collocated server



More information about the vlc-devel mailing list