[vlc-devel] [PATCH] gme: fixed out-of-memory/out-of-range tests

[Piotr Fusik]

Dnia 2012-03-24 18:10 Rémi Denis-Courmont napisał(a):

>Le vendredi 23 mars 2012 19:36:27 Piotr Fusik, vous avez écrit :
>> an_int > INT_MAX makes no sense. You can:
>> a. replace it with a_double > INT_MAX as I did
>> b. replace it with an_int < 0
>
>Eh? No you cannot do that because signed integer overflow is undefined in 
the 
>C language.
>
>> c. remove it
>> I don't see how an unsigned would help here.

I've looked into gme_seek and it returns error for negative arguments, so I 
remove the questionable comparison.

>> ---
>> modules/demux/gme.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>Applying: gme: fixed out-of-memory/out-of-range tests
>fatal: corrupt patch at line 10
>Patch failed at 0001 gme: fixed out-of-memory/out-of-range tests

Now as an attachment.

Piotr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gme-fixed-out-of-memory-out-of-range-tests.patch
Type: application/octet-stream
Size: 1162 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120326/20100717/attachment.obj>