[vlc-devel] [PATCH] libmp4: add macro MP4_GET4or8BYTES

Jean-Baptiste Kempf jb at videolan.org
Wed Mar 28 11:41:21 CEST 2012

On Tue, Mar 27, 2012 at 10:30:04AM -0400, Robert Forsman wrote :
> While that patch makes the code more compact, I am concerned that it
> affects readability of the code.  As sprawling as the previous version
> was, it matched up better with ISO 14496-12 section's syntax
> specification.

Well, yes, that is the question. The use of such a macro is that it
makes the code more compact and avoids getting 4 bytes if version = 1 or
such stupid mistakes that can be hard to proof-read.
But you have a point about the syntax.
I have no religion on that.

Best regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list