[vlc-devel] [vlc-commits] lua: remove add_callback and del_callback

[Pierre Ynard]

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon
> Mar 26 17:38:49 2012 +0300| [fe5df3d5b1bbe4918e0997c1f9875b2f1eab281a] |
> committer: Rémi Denis-Courmont
> 
> lua: remove add_callback and del_callback
> 
> add_callback could not work correctly with the (lack of) Lua threading
> support. Fortunately, it was not in use.

It's in use by extensions, that are now broken. The next victim will be
the http interface, since httpd callbacks have the same problem.

These are important features. I think the issue could be fixed by
protecting the lua state with a mutex. For a callback to run, the main
thread would have to either have exited, or be sleeping or polling or
inside another such function; and two different callbacks would be
mutually exclusive.

Regards,

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."